Why does the predicate call fail when I remove checks from it?

fuel · May 17, 2023, 12:19pm

Hi guys
I have this predicate, it builds well and all tests are pass

compolabs/ethglobal-predicate/blob/master/src/main.sw

predicate;
mod utils;

use std::u128::U128;
use std::outputs::{Output, output_amount, output_type};
use std::inputs::{input_count, input_owner};
use std::constants::ZERO_B256;
use utils::{
    input_coin_amount,
    input_coin_asset_id,
    output_coin_amount,
    output_coin_asset_id,
    output_coin_to,
    verify_output_coin,
};

configurable {
    ASSET0: b256 = ZERO_B256,
    ASSET1: b256 = ZERO_B256,
    MAKER: b256 = ZERO_B256,

This file has been truncated. show original

I have a few checks of output types here like that

github.com

compolabs/ethglobal-predicate/blob/84cd21c6883de6d8ed1d7d44b0df1cf7c2452010/src/main.sw#L57


      
              assert(price >= PRICE);
              // let price_decimals = 9;
              // let asset0_amount = U128::from_uint(input_coin_amount(0)); // 1000 USDC = 1000 * 1e6 = 1000_000_000
              // let asset1_amount = U128::from_uint(output_coin_amount(0)); // 200 UNI = 200 * 1e9 = 200_000_000_000
              // let exp = U128::from_uint(price_decimals + ASSET0_DECINALS - ASSET1_DECINALS);
              // let price = asset1_amount * U128::from_uint(10).pow(exp) / asset0_amount;
              // assert(price.as_u64().unwrap() >= PRICE);
              assert(PRICE > 0 && ASSET0 != ZERO_B256 && ASSET1 != ZERO_B256 && MAKER != ZERO_B256);
              assert(input_coin_asset_id(0) == ASSET0);
              assert(output_coin_asset_id(0) == ASSET1);
              match output_type(0) {
                  Output::Coin => (),
                  _ => revert(0),
              };
              assert(verify_output_coin(0));
              assert(output_coin_to(0) == MAKER);
              true
          }

After checking the sway repo I understand that checks on lines 58 and 61 do the same and I decided to remove one of them

But if I comment first one (lines 57-60) and run forc build && cargo test I have this errors during sending of money to predicate

thread 'local_tests::cancel_order_test::cancel_order_test' panicked at 'range end index 1576 out of range for slice of length 1448', /Users/alexey/.cargo/git/checkouts/fuels-rs-ce5f345b87bf4c50/386fab5/packages/fuels-core/src/lib.rs:26:13

But if I comment second check (line 61) I have this error during fulfillment or cancellation of the order

thread 'local_tests::fulfill_order_test::fulfill_order_test' panicked at 'called `Result::unwrap()` on an `Err` value: IOError(Custom { kind: Other, error: "Response errors; Invalid transaction: The transaction contains a predicate which failed to validate: TransactionId(0xecc07d4960e7bb216e716e1b40f94955b4a75aa67847dc9e74b70196254c4723)" })', tests/local_tests/fulfill_order_test.rs:95:6

If I comment both checks I have this error

thread 'local_tests::fulfill_order_test::fulfill_order_test' panicked at 'range end index 1576 out of range for slice of length 1424', /Users/alexey/.cargo/git/checkouts/fuels-rs-ce5f345b87bf4c50/386fab5/packages/fuels-core/src/lib.rs:26:13

Can you explain please how to fix that?

sarah · May 17, 2023, 4:00pm

The tests are passing for me, I wonder if this is just because of some caching?

fuel · May 17, 2023, 6:20pm

will check on the new forc version
Also, Is it ok to use that commands to remove the cache?

rm -rf Forc.lock Cargo.lock out target

Topic		Replies	Views
GM opcode will cause the VM to panic Sway	3	157	February 1, 2023
Predicate introspection - how to check a balance of particular asset_id that is not part of the immediate transaction? Sway	5	49	January 26, 2024
"Response errors; not enough coins to fit the target" on Beta 5 with Rust SDK v0.54 Sway	3	82	February 14, 2024
Can a contract make a call to a predicate? Sway	10	207	January 19, 2023
Is there a sway library to point to Predicate Sway	5	150	August 4, 2023

Why does the predicate call fail when I remove checks from it?

Related Topics